Page MenuHomePhabricator

chris (Chris Wetherill)
NOT A ROBOTAdministrator

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 1 2018, 5:54 PM (59 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Mon, Aug 19

chris requested review of D27: Separate global UI-building from app-specific page rendering.
Mon, Aug 19, 12:51 PM

Sun, Aug 18

chris added inline comments to D25: Initial user registration workflow.
Sun, Aug 18, 7:17 PM
chris accepted D26: use blue print.
Sun, Aug 18, 4:51 PM
chris added a comment to D25: Initial user registration workflow.

My rough plan following this diff is basically:

  • Switch up how we're doing page rendering since that's kind of murky current in terms of how we distinguish between 'build a sanitized HTML element' and 'render a specific page'. That can be cleaned up pretty easily and it's probably best to do that now while the codebase is still small
  • Build out the UI for the initial user registration flow. I think this will be the same deal as for a generic user registration, just with a 'this user is an admin' flag toggled
  • Build out some infrastructure around password management and credential checking. This'll be a "fun" learning adventure for me.
  • Build out the ORM piece so we can actually register a user and store their info to the database
  • Profit???
Sun, Aug 18, 4:48 PM
chris updated the diff for D25: Initial user registration workflow.

working redirect

Sun, Aug 18, 4:39 PM
chris added inline comments to D26: use blue print.
Sun, Aug 18, 4:26 PM
chris added a comment to D25: Initial user registration workflow.

This implementation is also wrong atm. Properly, I'll need to use some flask wrapper function for this since __init__ by definition can't actually return anything (the implication being that, short of raising an exception, we can't interrupt the normal course of action and say, "Return page Y instead of page X"). I'll fix this in a subsequent diff.

Sun, Aug 18, 2:55 PM
chris updated the test plan for D25: Initial user registration workflow.
Sun, Aug 18, 2:46 PM
chris updated the diff for D25: Initial user registration workflow.

Redirect to the appropriate registration route

Sun, Aug 18, 2:45 PM
chris retitled D25: Initial user registration workflow from WIP Registration workflow to Initial user registration workflow.
Sun, Aug 18, 2:28 PM
chris updated the diff for D25: Initial user registration workflow.

Super basic check to see if at least 1 admin account has been registered yet

Sun, Aug 18, 2:26 PM
chris added a comment to D26: use blue print.

So I think that for now we might want to keep the view and route folders separate, where view is more or less "How do we bring together all of the UI components on the page" and route is "What Python gets run when we go to a URL". It looks like you have all of the blueprint routing in view currently.

Sun, Aug 18, 1:39 PM

Sat, Aug 17

chris committed rSIM50d264f56ae2: Correct behavior when setting new configuration keys (authored by chris).
Correct behavior when setting new configuration keys
Sat, Aug 17, 7:50 AM
chris closed D21: Correct behavior when setting new configuration keys.
Sat, Aug 17, 7:50 AM

Mon, Aug 12

chris added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 7:45 PM
chris added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 6:11 PM
chris requested review of D25: Initial user registration workflow.
Mon, Aug 12, 5:40 PM
chris planned changes to D25: Initial user registration workflow.
Mon, Aug 12, 5:40 PM
chris committed rSIMcd9677225ad6: Clean up some internal imports (authored by chris).
Clean up some internal imports
Mon, Aug 12, 5:37 PM
chris closed D24: Clean up some internal imports.
Mon, Aug 12, 5:37 PM
chris added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 5:32 PM
chris committed rSIM0d172d4280cb: Enforce setup checks (authored by chris).
Enforce setup checks
Mon, Aug 12, 5:30 PM
chris closed D23: Enforce setup checks.
Mon, Aug 12, 5:30 PM
chris committed rSIM6cd8fbd13576: Correct check_database_reachable() setup check (authored by chris).
Correct check_database_reachable() setup check
Mon, Aug 12, 5:30 PM
chris closed D22: Correct check_database_reachable() setup check.
Mon, Aug 12, 5:30 PM
chris updated the diff for D22: Correct check_database_reachable() setup check.

Address review feedback

Mon, Aug 12, 5:23 PM
chris added a comment to D23: Enforce setup checks.
In D23#553, @brooke wrote:

@chris, maybe I should buy a mac this week.

Mon, Aug 12, 5:07 PM

Sun, Aug 11

chris updated the diff for D24: Clean up some internal imports.

Updates after rebasing

Sun, Aug 11, 4:33 PM
chris requested review of D24: Clean up some internal imports.
Sun, Aug 11, 4:24 PM
chris requested review of D23: Enforce setup checks.
Sun, Aug 11, 3:37 PM
chris requested review of D22: Correct check_database_reachable() setup check.
Sun, Aug 11, 3:27 PM
chris updated the summary of D21: Correct behavior when setting new configuration keys.
Sun, Aug 11, 3:04 PM
chris requested review of D21: Correct behavior when setting new configuration keys.
Sun, Aug 11, 3:04 PM
chris committed rSIM6f1d949f807c: Add utility for managing local configuration settings (authored by chris).
Add utility for managing local configuration settings
Sun, Aug 11, 2:07 PM
chris closed D20: Add utility for managing local configuration settings.
Sun, Aug 11, 2:07 PM
chris updated the diff for D20: Add utility for managing local configuration settings.
  • Properly handle nested arguments
Sun, Aug 11, 2:07 PM
chris committed rSIM69a86b9c8a57: Perform databse setup checks (authored by chris).
Perform databse setup checks
Sun, Aug 11, 2:06 PM
chris closed D17: Perform databse setup checks.
Sun, Aug 11, 2:06 PM
chris accepted D19: updates based on feedbacks from D18.
Sun, Aug 11, 2:01 PM
chris added inline comments to D19: updates based on feedbacks from D18.
Sun, Aug 11, 1:54 PM

Thu, Aug 8

chris requested changes to D19: updates based on feedbacks from D18.

Whoops! Sorry, almost forgot: mind fixing the PEP lint issues also?

Thu, Aug 8, 6:37 PM
chris accepted D19: updates based on feedbacks from D18.
Thu, Aug 8, 6:36 PM

Sun, Aug 4

chris added a comment to D19: updates based on feedbacks from D18.

Looking good! Couple minor comments here and there.

Sun, Aug 4, 7:41 PM
chris updated the diff for D20: Add utility for managing local configuration settings.

Removed an extra debug statement

Sun, Aug 4, 6:49 PM
chris requested review of D20: Add utility for managing local configuration settings.
Sun, Aug 4, 6:49 PM
chris retitled D17: Perform databse setup checks from WIP to Perform databse setup checks.
Sun, Aug 4, 2:58 PM
chris updated the diff for D17: Perform databse setup checks.

fleshed out implementation

Sun, Aug 4, 2:57 PM
chris committed rSIM24d931f7cdb6: Extend `SimplexEnv.build_configuration_stack()` (authored by chris).
Extend `SimplexEnv.build_configuration_stack()`
Sun, Aug 4, 1:35 PM
chris closed D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Aug 4, 1:35 PM
chris committed rSIMa330d7c56569: Adds ConfigurationLocalSource class (authored by chris).
Adds ConfigurationLocalSource class
Sun, Aug 4, 1:19 PM
chris closed D15: Adds ConfigurationLocalSource class.
Sun, Aug 4, 1:19 PM

Sun, Jul 28

chris added inline comments to D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Jul 28, 8:22 PM
chris added inline comments to D15: Adds ConfigurationLocalSource class.
Sun, Jul 28, 8:16 PM
chris requested changes to D18: implement select & html classes.
Sun, Jul 28, 5:11 PM
chris planned changes to D17: Perform databse setup checks.
Sun, Jul 28, 3:50 PM
chris requested review of D17: Perform databse setup checks.
Sun, Jul 28, 3:50 PM
chris updated the diff for D16: Extend `SimplexEnv.build_configuration_stack()`.

Correct a bunch of silly class stuff

Sun, Jul 28, 3:17 PM
chris updated the diff for D16: Extend `SimplexEnv.build_configuration_stack()`.

Fix an import issue

Sun, Jul 28, 1:38 PM
chris requested review of D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Jul 28, 1:30 PM
chris added a comment to D15: Adds ConfigurationLocalSource class.

@brooke --- I kind of went to town on imports in this diff. It's all just cosmetic stuff, so go ahead and ignore that when looking at the SimplexConfigSource stuff

Sun, Jul 28, 1:00 PM
chris updated the diff for D15: Adds ConfigurationLocalSource class.

Just go ham on the imports

Sun, Jul 28, 12:59 PM
chris updated the diff for D15: Adds ConfigurationLocalSource class.

Unbreak some imports

Sun, Jul 28, 12:36 PM
chris requested review of D15: Adds ConfigurationLocalSource class.
Sun, Jul 28, 12:27 PM

Wed, Jul 24

chris added a comment to D14: display upload data and implement user input data type.

@brooke — I'll need you to:

Wed, Jul 24, 7:45 PM
chris requested review of D14: display upload data and implement user input data type.
Wed, Jul 24, 7:44 PM
chris committed rSIM7af94bff8eaa: display upload data (authored by brooke).
display upload data
Wed, Jul 24, 7:40 PM
chris added a comment to D13: display upload data.
In D13#297, @brooke wrote:

$ arc land
Landing current branch 'tmp'.
TARGET Landing onto "dev", selected by "arc.land.onto.default" configuration.
REMOTE Using remote "origin", the default remote under git.
FETCH Fetching origin/dev...
Authenticated to phabricator.tbmh.org ([50.116.49.41]:2222).
Transferred: sent 2812, received 3052 bytes, in 0.6 seconds
Bytes per second: sent 4425.4, received 4803.1
This commit will be landed:

  • a494ef1 rebase

Usage Exception: arc can not identify which revision exists on branch 'tmp'. Update the revision with recent changes to synchronize the branch name and hashes, or use 'arc amend' to amend the commit message at HEAD, or use '--revision <id>' to select a revision explicitly.

Wed, Jul 24, 7:27 PM
chris added a comment to D13: display upload data.

weird. Just git rebase --skip

Wed, Jul 24, 7:22 PM
chris accepted D13: display upload data.
Wed, Jul 24, 7:10 PM
chris added a comment to D13: display upload data.
git reset --hard origin/dev
arc patch --diff 33
arc diff --update D13
git checkout -b tmp
arc patch --diff 37
arc diff HEAD^
git checkout dev
# wait for Chris to accept D13
arc land
git checkout tmp
git rebase dev
# wait for Chris to accept diff
arc land
Wed, Jul 24, 7:07 PM

Jul 21 2019

chris added a comment to D13: display upload data.

Could you move this most recent commit into its own code review? I think things are going to get too messy here otherwise. Thanks!

Jul 21 2019, 8:14 PM
chris committed rSIM22a7fc38e311: Add manage_storage script for quickstart (authored by chris).
Add manage_storage script for quickstart
Jul 21 2019, 4:57 PM
chris closed D12: Add manage_storage script for quickstart.
Jul 21 2019, 4:57 PM
chris committed rSIM43bbabb32783: Storage management workflow (authored by chris).
Storage management workflow
Jul 21 2019, 4:57 PM
chris closed D11: Storage management workflow.
Jul 21 2019, 4:57 PM
chris updated the diff for D12: Add manage_storage script for quickstart.

Correct some SQL stuffs

Jul 21 2019, 4:56 PM
chris added a comment to D12: Add manage_storage script for quickstart.
In D12#258, @chris wrote:

I think approximate next steps from here will be to:
[...]

Jul 21 2019, 4:14 PM
chris added a comment to D13: display upload data.

Couple more super minor comments, then you're good to go!

Jul 21 2019, 4:13 PM
chris added a comment to D12: Add manage_storage script for quickstart.

I think approximate next steps from here will be to:

  • Add a global check that the database is reachable per credentials stored in an arbitrary config file
  • If unreachable, redirect to an error page that prompts the user to run some config command. E.g., config set mysql.port=3306 or whatever else
    • Ideally, this should do a somewhat comprehensive check so that the instance admin has a fairly complete list of all required setup steps in one view (as opposed to having to continually reload the page to find the next broken thing in a hellish and neverending game of whack-a-mole)
  • If reachable, check that all of the quickstart scripts have run. I need to figure out a way to do this efficiently and how to extend it to arbitrary patches delivered from the upstream
    • If not, run the quickstart scripts. Ideally with some error handling. But if not, I'd be okay with that for the short term (I mean, not really, but I'm just lazy)
  • If everything's good so far, actually go ahead and render the page
Jul 21 2019, 4:11 PM
chris updated the test plan for D12: Add manage_storage script for quickstart.
Jul 21 2019, 4:05 PM
chris updated the test plan for D12: Add manage_storage script for quickstart.
Jul 21 2019, 4:05 PM
chris updated the diff for D12: Add manage_storage script for quickstart.

Working implementation

Jul 21 2019, 4:02 PM
chris added inline comments to D13: display upload data.
Jul 21 2019, 3:49 PM
chris requested review of D12: Add manage_storage script for quickstart.
Jul 21 2019, 2:51 PM
chris committed rSIM7bb4d6fcd7b4: Add basic storage management API (authored by chris).
Add basic storage management API
Jul 21 2019, 2:31 PM
chris closed D10: Add basic storage management API.
Jul 21 2019, 2:31 PM
chris requested review of D11: Storage management workflow.
Jul 21 2019, 2:31 PM
chris committed rSIMb9d62b342c02: Add a ListItemView class (authored by chris).
Add a ListItemView class
Jul 21 2019, 2:22 PM
chris closed D9: Add a ListItemView class.
Jul 21 2019, 2:22 PM
chris updated the diff for D9: Add a ListItemView class.

Fixed copy/paste thingy

Jul 21 2019, 2:21 PM
chris added inline comments to D9: Add a ListItemView class.
Jul 21 2019, 2:20 PM
chris requested review of D10: Add basic storage management API.
Jul 21 2019, 2:08 PM
chris closed D8: Make page view functional.
Jul 21 2019, 2:03 PM
chris committed rSIM8e1e656314d3: Make page view functional (authored by chris).
Make page view functional
Jul 21 2019, 2:03 PM
chris added inline comments to D8: Make page view functional.
Jul 21 2019, 2:02 PM

Jul 20 2019

chris updated the test plan for D9: Add a ListItemView class.
Jul 20 2019, 5:40 PM
chris requested review of D9: Add a ListItemView class.
Jul 20 2019, 5:40 PM

Jul 18 2019

chris triaged T24: Prediction rule reshaping as Wishlist priority.
Jul 18 2019, 7:14 PM · Simplex

Jul 16 2019

chris accepted D7: remove upload and update data.
Jul 16 2019, 9:39 PM
chris added a comment to D8: Make page view functional.

Jul 16 2019, 9:16 PM