Page MenuHomePhabricator
Feed All Stories

Mon, Aug 19

chris requested review of D27: Separate global UI-building from app-specific page rendering.
Mon, Aug 19, 12:51 PM

Sun, Aug 18

chris added inline comments to D25: Initial user registration workflow.
Sun, Aug 18, 7:17 PM
brooke added inline comments to D25: Initial user registration workflow.
Sun, Aug 18, 7:01 PM
brooke committed rSIMe201001f0ebc: use blue print (authored by brooke).
use blue print
Sun, Aug 18, 4:53 PM
brooke closed D26: use blue print.
Sun, Aug 18, 4:53 PM
chris accepted D26: use blue print.
Sun, Aug 18, 4:51 PM
brooke updated the diff for D26: use blue print.
  • address code review issues
  • fix lint issues
  • make it work after rebasing
Sun, Aug 18, 4:50 PM
chris added a comment to D25: Initial user registration workflow.

My rough plan following this diff is basically:

  • Switch up how we're doing page rendering since that's kind of murky current in terms of how we distinguish between 'build a sanitized HTML element' and 'render a specific page'. That can be cleaned up pretty easily and it's probably best to do that now while the codebase is still small
  • Build out the UI for the initial user registration flow. I think this will be the same deal as for a generic user registration, just with a 'this user is an admin' flag toggled
  • Build out some infrastructure around password management and credential checking. This'll be a "fun" learning adventure for me.
  • Build out the ORM piece so we can actually register a user and store their info to the database
  • Profit???
Sun, Aug 18, 4:48 PM
chris updated the diff for D25: Initial user registration workflow.

working redirect

Sun, Aug 18, 4:39 PM
chris added inline comments to D26: use blue print.
Sun, Aug 18, 4:26 PM
brooke updated the diff for D26: use blue print.
  • fix lint issues
Sun, Aug 18, 4:15 PM
brooke updated the diff for D26: use blue print.
  • address code review issues
Sun, Aug 18, 3:16 PM
chris added a comment to D25: Initial user registration workflow.

This implementation is also wrong atm. Properly, I'll need to use some flask wrapper function for this since __init__ by definition can't actually return anything (the implication being that, short of raising an exception, we can't interrupt the normal course of action and say, "Return page Y instead of page X"). I'll fix this in a subsequent diff.

Sun, Aug 18, 2:55 PM
chris updated the test plan for D25: Initial user registration workflow.
Sun, Aug 18, 2:46 PM
chris updated the diff for D25: Initial user registration workflow.

Redirect to the appropriate registration route

Sun, Aug 18, 2:45 PM
chris retitled D25: Initial user registration workflow from WIP Registration workflow to Initial user registration workflow.
Sun, Aug 18, 2:28 PM
chris updated the diff for D25: Initial user registration workflow.

Super basic check to see if at least 1 admin account has been registered yet

Sun, Aug 18, 2:26 PM
brooke added a comment to D26: use blue print.
  1. I will move things from view to route.
  2. I will update the UI items:
  3. style header
  4. style button
  5. combine tables
  6. replace index with headers
Sun, Aug 18, 1:45 PM
chris added a comment to D26: use blue print.

So I think that for now we might want to keep the view and route folders separate, where view is more or less "How do we bring together all of the UI components on the page" and route is "What Python gets run when we go to a URL". It looks like you have all of the blueprint routing in view currently.

Sun, Aug 18, 1:39 PM

Sat, Aug 17

chris committed rSIM50d264f56ae2: Correct behavior when setting new configuration keys (authored by chris).
Correct behavior when setting new configuration keys
Sat, Aug 17, 7:50 AM
chris closed D21: Correct behavior when setting new configuration keys.
Sat, Aug 17, 7:50 AM

Wed, Aug 14

brooke accepted D21: Correct behavior when setting new configuration keys.
Wed, Aug 14, 8:11 PM
brooke added inline comments to D25: Initial user registration workflow.
Wed, Aug 14, 8:08 PM
brooke updated the summary of D26: use blue print.
Wed, Aug 14, 8:05 PM
brooke requested review of D26: use blue print.
Wed, Aug 14, 7:57 PM

Mon, Aug 12

chris added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 7:45 PM
brooke added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 7:08 PM
chris added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 6:11 PM
brooke added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 6:03 PM
chris requested review of D25: Initial user registration workflow.
Mon, Aug 12, 5:40 PM
chris planned changes to D25: Initial user registration workflow.
Mon, Aug 12, 5:40 PM
chris committed rSIMcd9677225ad6: Clean up some internal imports (authored by chris).
Clean up some internal imports
Mon, Aug 12, 5:37 PM
chris closed D24: Clean up some internal imports.
Mon, Aug 12, 5:37 PM
chris added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 5:32 PM
brooke added inline comments to D21: Correct behavior when setting new configuration keys.
Mon, Aug 12, 5:31 PM
chris committed rSIM0d172d4280cb: Enforce setup checks (authored by chris).
Enforce setup checks
Mon, Aug 12, 5:30 PM
chris closed D23: Enforce setup checks.
Mon, Aug 12, 5:30 PM
chris committed rSIM6cd8fbd13576: Correct check_database_reachable() setup check (authored by chris).
Correct check_database_reachable() setup check
Mon, Aug 12, 5:30 PM
chris closed D22: Correct check_database_reachable() setup check.
Mon, Aug 12, 5:30 PM
brooke accepted D22: Correct check_database_reachable() setup check.
Mon, Aug 12, 5:27 PM
chris updated the diff for D22: Correct check_database_reachable() setup check.

Address review feedback

Mon, Aug 12, 5:23 PM
brooke requested changes to D22: Correct check_database_reachable() setup check.
Mon, Aug 12, 5:18 PM
brooke accepted D22: Correct check_database_reachable() setup check.
Mon, Aug 12, 5:18 PM
chris added a comment to D23: Enforce setup checks.
In D23#553, @brooke wrote:

@chris, maybe I should buy a mac this week.

Mon, Aug 12, 5:07 PM
brooke accepted D23: Enforce setup checks.
Mon, Aug 12, 5:06 PM
brooke added a comment to D23: Enforce setup checks.

@chris, maybe I should buy a mac this week. Looks like some of the imports will be updated by D24.

Mon, Aug 12, 5:06 PM
brooke accepted D24: Clean up some internal imports.
Mon, Aug 12, 5:01 PM

Sun, Aug 11

chris updated the diff for D24: Clean up some internal imports.

Updates after rebasing

Sun, Aug 11, 4:33 PM
chris requested review of D24: Clean up some internal imports.
Sun, Aug 11, 4:24 PM
chris requested review of D23: Enforce setup checks.
Sun, Aug 11, 3:37 PM
chris requested review of D22: Correct check_database_reachable() setup check.
Sun, Aug 11, 3:27 PM
chris updated the summary of D21: Correct behavior when setting new configuration keys.
Sun, Aug 11, 3:04 PM
chris requested review of D21: Correct behavior when setting new configuration keys.
Sun, Aug 11, 3:04 PM
brooke committed rSIMaf6cabbf9617: updates based on feedbacks from D18 (authored by brooke).
updates based on feedbacks from D18
Sun, Aug 11, 2:12 PM
brooke closed D19: updates based on feedbacks from D18.
Sun, Aug 11, 2:12 PM
chris committed rSIM6f1d949f807c: Add utility for managing local configuration settings (authored by chris).
Add utility for managing local configuration settings
Sun, Aug 11, 2:07 PM
chris closed D20: Add utility for managing local configuration settings.
Sun, Aug 11, 2:07 PM
chris updated the diff for D20: Add utility for managing local configuration settings.
  • Properly handle nested arguments
Sun, Aug 11, 2:07 PM
chris committed rSIM69a86b9c8a57: Perform databse setup checks (authored by chris).
Perform databse setup checks
Sun, Aug 11, 2:06 PM
chris closed D17: Perform databse setup checks.
Sun, Aug 11, 2:06 PM
chris accepted D19: updates based on feedbacks from D18.
Sun, Aug 11, 2:01 PM
brooke updated the diff for D19: updates based on feedbacks from D18.
  • fix style issues
Sun, Aug 11, 2:00 PM
chris added inline comments to D19: updates based on feedbacks from D18.
Sun, Aug 11, 1:54 PM
brooke accepted D20: Add utility for managing local configuration settings.
Sun, Aug 11, 1:54 PM
brooke updated the diff for D19: updates based on feedbacks from D18.
  • fix lint issues
Sun, Aug 11, 1:50 PM
brooke accepted D17: Perform databse setup checks.
Sun, Aug 11, 1:43 PM

Fri, Aug 9

brooke added inline comments to D17: Perform databse setup checks.
Fri, Aug 9, 9:58 PM

Thu, Aug 8

chris requested changes to D19: updates based on feedbacks from D18.

Whoops! Sorry, almost forgot: mind fixing the PEP lint issues also?

Thu, Aug 8, 6:37 PM
chris accepted D19: updates based on feedbacks from D18.
Thu, Aug 8, 6:36 PM
brooke abandoned D18: implement select & html classes.
Thu, Aug 8, 6:32 PM
brooke updated the diff for D19: updates based on feedbacks from D18.
  • update codes based on review feedbacks
Thu, Aug 8, 6:32 PM
brooke added inline comments to D19: updates based on feedbacks from D18.
Thu, Aug 8, 6:31 PM

Sun, Aug 4

brooke updated the diff for D19: updates based on feedbacks from D18.
  • get selected item from dtypes
Sun, Aug 4, 8:06 PM
chris added a comment to D19: updates based on feedbacks from D18.

Looking good! Couple minor comments here and there.

Sun, Aug 4, 7:41 PM
chris updated the diff for D20: Add utility for managing local configuration settings.

Removed an extra debug statement

Sun, Aug 4, 6:49 PM
chris requested review of D20: Add utility for managing local configuration settings.
Sun, Aug 4, 6:49 PM
brooke updated the diff for D19: updates based on feedbacks from D18.
  • remove hard coded style
Sun, Aug 4, 5:10 PM
brooke requested review of D19: updates based on feedbacks from D18.
Sun, Aug 4, 5:08 PM
chris retitled D17: Perform databse setup checks from WIP to Perform databse setup checks.
Sun, Aug 4, 2:58 PM
chris updated the diff for D17: Perform databse setup checks.

fleshed out implementation

Sun, Aug 4, 2:57 PM
chris committed rSIM24d931f7cdb6: Extend `SimplexEnv.build_configuration_stack()` (authored by chris).
Extend `SimplexEnv.build_configuration_stack()`
Sun, Aug 4, 1:35 PM
chris closed D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Aug 4, 1:35 PM
brooke accepted D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Aug 4, 1:35 PM
chris committed rSIMa330d7c56569: Adds ConfigurationLocalSource class (authored by chris).
Adds ConfigurationLocalSource class
Sun, Aug 4, 1:19 PM
chris closed D15: Adds ConfigurationLocalSource class.
Sun, Aug 4, 1:19 PM
brooke accepted D15: Adds ConfigurationLocalSource class.
Sun, Aug 4, 1:19 PM

Tue, Jul 30

brooke added inline comments to D18: implement select & html classes.
Tue, Jul 30, 8:36 PM

Sun, Jul 28

chris added inline comments to D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Jul 28, 8:22 PM
chris added inline comments to D15: Adds ConfigurationLocalSource class.
Sun, Jul 28, 8:16 PM
brooke added inline comments to D16: Extend `SimplexEnv.build_configuration_stack()`.
Sun, Jul 28, 8:06 PM
brooke added inline comments to D15: Adds ConfigurationLocalSource class.
Sun, Jul 28, 7:51 PM
chris requested changes to D18: implement select & html classes.
Sun, Jul 28, 5:11 PM
brooke updated the diff for D18: implement select & html classes.

update after merging

Sun, Jul 28, 4:05 PM
brooke abandoned D14: display upload data and implement user input data type.
Sun, Jul 28, 4:03 PM
brooke commandeered D14: display upload data and implement user input data type.
Sun, Jul 28, 4:03 PM
brooke requested review of D18: implement select & html classes.
Sun, Jul 28, 3:57 PM
chris planned changes to D17: Perform databse setup checks.
Sun, Jul 28, 3:50 PM
chris requested review of D17: Perform databse setup checks.
Sun, Jul 28, 3:50 PM
chris updated the diff for D16: Extend `SimplexEnv.build_configuration_stack()`.

Correct a bunch of silly class stuff

Sun, Jul 28, 3:17 PM
chris updated the diff for D16: Extend `SimplexEnv.build_configuration_stack()`.

Fix an import issue

Sun, Jul 28, 1:38 PM